Asset-Manager: switch to EFS CSI driver and PersistentVolumeClaim #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sengi
approved these changes
Aug 16, 2022
| server: "{{ .Values.clamavNFS }}" | ||
| path: / | ||
| persistentVolumeClaim: | ||
| claimName: clamav-db |
There was a problem hiding this comment.
nit: double indent?
Suggested change
| claimName: clamav-db | |
| claimName: clamav-db |
| @@ -0,0 +1,11 @@ | |||
| apiVersion: v1 | |||
| kind: PersistentVolumeClaim | |||
There was a problem hiding this comment.
I'm guessing the EFS CSI driver takes care of the PersistentVolume side of things and that's why we don't define a PersistentVolume ourselves? Is that right?
Due to the issue with non-root asset-manager trying to use a root NFS volume created in AWS/terraform directly. We move to using the EFS CSI driver and PersistentVolumeClaim. See related PR: alphagov/govuk-infrastructure#725
fredericfran-gds
force-pushed
the
efs_asset_manager
branch
from
dc6aaec to
029d632
Compare
nimalank7
added a commit
to alphagov/govuk-infrastructure
that referenced
this pull request
Dec 5, 2024
Description: - #725 introduced the EBS CSI Driver which created EFS for ClamAV - Next alphagov/govuk-helm-charts#508 allowed ClamAV to talk to EFS over NFS exposing over clamav-db-govuk.integration.govuk-internal.digital - However this didn’t work so ClamAV was switched to use the EFS CSI driver in alphagov/govuk-helm-charts#514. But this removes the reference to clamav-db-govuk.integration.govuk-internal.digital - #790 removes the EFS CSI driver - Next alphagov/govuk-helm-charts#572 makes ClamAV share the EFS instance via the same NFS mount as asset manager. - Now there is a dangling reference to ClamAV EFS instance which can be safely removed as nothing references it anymore. - As part of alphagov/govuk-helm-charts#1883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the issue with non-root asset-manager trying to use a root
NFS volume created in AWS/terraform directly. We move to using the
EFS CSI driver and PersistentVolumeClaim.
See related PR: alphagov/govuk-infrastructure#725